Track passing/failing tests in fiber#8169
Conversation
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
Why does this need a work around for the test failure when the other Fiber test runner doesn't?
The strategy seems sound but it looks like this causes a Travis error. Something not found.
| return Object.assign({}, flags, { | ||
| useFiber: !!process.env.REACT_DOM_JEST_USE_FIBER, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Don't we somehow have a flag already?
There was a problem hiding this comment.
Yeah but it requires changing ReactDOMFeatureFlags.js which feels safe on Travis and not as safe if you might have local changes.
|
The other one failed on my machine too. |
sophiebits
force-pushed
the
fiber-test-tracking
branch
from
5a42d00 to
34553aa
Compare
|
ok |
| "gulp-util": "^3.0.7", | ||
| "gzip-js": "~0.3.2", | ||
| "jest": "^15.1.1", | ||
| "jest-cli": "^15.1.1", |
There was a problem hiding this comment.
Is the jest package just an alias for jest-cli? Only one is needed I think.
There was a problem hiding this comment.
jest seemingly just delegates to jest-cli but it does have the same exports so (y).
sophiebits
force-pushed
the
fiber-test-tracking
branch
from
34553aa to
47ff276
Compare
Run scripts/fiber/record-tests to re-record, then check git diff to see what you changed.
sophiebits
force-pushed
the
fiber-test-tracking
branch
from
47ff276 to
79cfa85
Compare
| scripts/fiber/record-tests | ||
| git --no-pager diff scripts/fiber | ||
| FIBER_TESTS_STATUS=$(git status --porcelain scripts/fiber) | ||
| test -z "$FIBER_TESTS_STATUS" |
There was a problem hiding this comment.
Does this mean that any time anyone adds a passing test, unrelated to Fiber, in a PR we will get a Travis error on the PR?
There was a problem hiding this comment.
That was my intention. I figured it was good to know whether your new test passes in Fiber. Not good?
There was a problem hiding this comment.
It's good for the team but might be noisy for third-party PR. Not too worried about it though. Let's see how it works out.
|
@aweary Heads up if you didn't see: everyone needs to run scripts/fiber/record-tests when adding/removing tests (or breaking/fixing them in the fiber reconciler) or else CI will fail now. This way it's really obvious whether tests pass or fail in fiber when looking at a diff. |
|
@spicyj thanks, I didn't see this. I'll make sure to do this 👍 |
* Work around jest toEqual bug in ReactTreeTraversal  * Track passing/failing tests in fiber Run scripts/fiber/record-tests to re-record, then check git diff to see what you changed.
5 participants
Run scripts/fiber/record-tests to re-record, then check git diff to see what you changed.